BOM-2781: New codemods on OpenedX (4) #28779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzulqarnain1
force-pushed
the
codemods-openedx-4
branch
from
4101222 to
10fbced
Compare
UsamaSadiq
approved these changes
Sep 23, 2021
jmbowman
reviewed
Oct 4, 2021
| @@ -0,0 +1,23 @@ | |||
| # Generated by Django 2.2.24 on 2021-09-23 09:35 | |||
Contributor
There was a problem hiding this comment.
Given that we need to edit the previous migrations anyway, it feels like we should be able to do it in a way that renders this migration unnecessary. Just update the field definitions in the previous migrations to match the new verisons here, I don't think it should produce any actual database changes.
| @@ -0,0 +1,18 @@ | |||
| # Generated by Django 2.2.24 on 2021-09-23 09:35 | |||
Contributor
There was a problem hiding this comment.
Same here, can we avoid this new migration?
| from django.test.utils import override_settings | ||
| from django.urls import reverse | ||
| from django.utils.http import urlquote_plus | ||
| from urllib.parse import quote_plus |
Contributor
There was a problem hiding this comment.
Probably should move for isort compliance.
| from django.contrib import auth | ||
| from django.template.loader import render_to_string | ||
| from django.utils.http import urlquote_plus | ||
| from urllib.parse import quote_plus |
| @@ -0,0 +1,23 @@ | |||
| # Generated by Django 2.2.24 on 2021-09-23 09:35 | |||
Contributor
There was a problem hiding this comment.
Can we avoid creating this one also?
mzulqarnain1
force-pushed
the
codemods-openedx-4
branch
from
d7b8780 to
db3ab9b
Compare
mzulqarnain1
force-pushed
the
codemods-openedx-4
branch
from
db3ab9b to
3b6269a
Compare
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
mraarif
pushed a commit
that referenced
this pull request
Nov 4, 2021
cmltaWt0
pushed a commit
to cmltaWt0/edx-platform
that referenced
this pull request
Dec 13, 2021
edx-community-bot
added a commit
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked 7aadf55 from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781